Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to put prescription lenses in role-related optics #5367

Merged
merged 9 commits into from
Jan 14, 2024

Conversation

Staykeu
Copy link
Contributor

@Staykeu Staykeu commented Jan 2, 2024

About the pull request

Adds the ability to apply lenses from prescription eyewear into HUDs/mesons/specialist optics.

Explain why it's good for the game

QoL change that makes life easier for those that have characters with impaired vision, allows the use of these eyepieces without obscuring the mask slot, be it reserved for smokes, scarfs, coifs, etc.

Testing Photographs and Procedure

Screenshots & Videos

N/A

Changelog

🆑 Stakeyng
add: Added the ability to combine prescription glasses with eyewear for varying roles
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jan 2, 2024
@Staykeu Staykeu changed the title Prescription-eyewear Adds the ability to put prescription lenses in multiple optics Jan 2, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine (its code I wrote) and can confirm working in game.

code/modules/clothing/glasses/glasses.dm Outdated Show resolved Hide resolved
@Staykeu Staykeu requested a review from fira January 2, 2024 12:13
@Staykeu Staykeu requested a review from Drulikar January 2, 2024 15:30
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine.

@Zonespace27 Zonespace27 added Feature Feature coder badge and removed Quality of Life Make the game harder to play labels Jan 2, 2024
@Staykeu Staykeu changed the title Adds the ability to put prescription lenses in multiple optics Adds the ability to put prescription lenses in role-related optics Jan 3, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 14, 2024
@Drulikar Drulikar added this pull request to the merge queue Jan 14, 2024
Merged via the queue into cmss13-devs:master with commit f76b5c5 Jan 14, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 14, 2024
@Staykeu Staykeu deleted the prescription-eyewear branch January 29, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants