-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix and small refactor of Areas in lower deck on almayer part2 #5373
Conversation
make hull area at 0C want the place to be colder. adding port and star bow hull lower deck
adding two areas
added constru and s-bow maintainenance area
those change make sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes to maint intended? See https://github.com/cmss13-devs/cmss13/pull/5373/checks?check_run_id=20164023790
The old locations for these hazard lines seemed to line up with the entire ship.
@Drulikar |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mapping is fine, just change the area thing and it's good
Co-authored-by: Nanu308 <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Engage merging.
About the pull request
properly made some comment to doc standard with ///
create a new area type /area/almayer/mnt
it will be a parent to hull area.
changed hull/lower_hull to hull/lower (same for upper)
added two maintenance areas /area/almayer/mnt/lower/constr and /area/almayer/mnt/lower/s_bow
added a bunch of missing apc because of all the recent change in hull areas...
map tweak hull areas where a lot to bright so i moved a bunch of light (hope it doesn't break the freeze....)
Explain why it's good for the game
1-making hull area match well separated area will help a lot people to use the system to locate dead people etc....
2-making hulls areas darker will add a more fitting vibe to it.
3-seperate hull and maint area is in preparation to the future also allow to know hull area area with access to exterior hull
and know maint aren't
4-adding more apc will allow them have area being unpowered...
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
fix: corrected the name of an area from "Lower Deck Starboard Hull" to "Lower Deck Starboard-Aft Hull".
fix: added apc's to area that where missing one.
maptweak: added some areas to almayers (constr site, Starboard-Bow Maintenance, Bow Hull(port and starboard),cryo maintenance.
/:cl: