Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes donor helmets not having an accessory slot #5380

Conversation

Waseemq1235
Copy link
Contributor

@Waseemq1235 Waseemq1235 commented Jan 4, 2024

About the pull request

Fixes donor helmets not having an accessory slot by making have the garb overlay on by default. Before this fix, Initialization code essentially removes that accessory slot as soon as the helmet is loaded in as the helmet lacks garb overlay.

Explain why it's good for the game

Let them have that slot.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixed donor helmets not having an accessory slot.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 4, 2024
@Waseemq1235 Waseemq1235 changed the title does that Fixes donor helmets not having an accessory slot Jan 4, 2024
@fira
Copy link
Member

fira commented Jan 6, 2024

Isn't that going to mess with visuals for the vast majority of them?

@Waseemq1235
Copy link
Contributor Author

Isn't that going to mess with visuals for the vast majority of them?

They can right click the helmet and toggle garb, it's a lil' verb they get.

@fira
Copy link
Member

fira commented Jan 8, 2024

Yeah i know but what i mean is that given how it is right now i figure the majority are meant to have it disabled

@realforest2001
Copy link
Member

As fira said this is largely intended

@Waseemq1235
Copy link
Contributor Author

Sure then I'll change it so it still starts with garb overlay off by default.

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@harryob harryob marked this pull request as draft January 18, 2024 16:11
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 26, 2024
@github-actions github-actions bot closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants