Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes runtime in fruit.dm #5381

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

Birdtalon
Copy link
Contributor

@Birdtalon Birdtalon commented Jan 4, 2024

About the pull request

affected_message() should take four arguments in these two cases message_viewer was missing and would pass null which runtimes to_chat()

[2024-01-04 14:16:27.696] runtime error: Empty or null string in to_chat proc call.
 - proc name: to chat (/proc/to_chat)
 -   source file: code/modules/tgchat/to_chat.dm,89
 -   usr: Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian)
 -   src: null
 -   usr.loc: the floor (96,80,2) (/turf/open/floor)
 -   call stack:
 - to chat(Prime Defender (XX-410) (/mob/living/carbon/xenomorph/defender), "", null, "", 0, 1, 1, 0)
 - Prime Defender (XX-410) (/mob/living/carbon/xenomorph/defender): show message(null, 1, null, null, 0)
 - Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian): affected message(Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), "<span class=\'helpful\'>You <b...", "<span class=\'helpful\'>Ancien...", null)
 - Greater Resin Fruit (/obj/item/reagent_container/food/snacks/resin_fruit/greater): attack(Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian))
 - Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian): attackby(Greater Resin Fruit (/obj/item/reagent_container/food/snacks/resin_fruit/greater), Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), /list (/list))
 - Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian): attackby(Greater Resin Fruit (/obj/item/reagent_container/food/snacks/resin_fruit/greater), Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), /list (/list))
 - Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian): click adjacent(Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), Greater Resin Fruit (/obj/item/reagent_container/food/snacks/resin_fruit/greater), /list (/list))
 - Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian): do click(Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), the floor (96,80,2) (/turf/open/floor), "icon-x=38;icon-y=18;left=1;but...")
 - **** (/client): Click(Ancient Praetorian (L-725) (/mob/living/carbon/xenomorph/praetorian), the floor (96,80,2) (/turf/open/floor), "mapwindow.map", "icon-x=38;icon-y=18;left=1;but...")

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Runtime when consuming xeno fruits.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 4, 2024
@harryob harryob added this pull request to the merge queue Jan 6, 2024
Merged via the queue into cmss13-devs:master with commit 63b888a Jan 6, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 6, 2024
@Birdtalon Birdtalon deleted the froot_runtime branch February 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants