Fixes monkey orbiting breaking the camera #5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes orbiting a monkey/farwa/stok/etc. locking your camera onto it.
This was happening due to
RegisterSignal(src, COMSIG_MOVABLE_MOVED, PROC_REF(observer_move_react))not being called if the target mob didn't have a HUD, meaning that the client'seyewouldn't be set back to their body when they tried moving away.I also moved the
COMSIG_PARENT_QDELETINGone over too so that the same doesn't happen if the target mob is deleted.(The other signals all seem to be HUD related.)
Explain why it's good for the game
Bug!
Testing Photographs and Procedure
Screenshots & Videos
Before:
Before.1.mp4
Before.2.mp4
After:
After.1.mp4
After.2.mp4
Changelog
🆑
fix: Fixed observing a monkey/farwa/stok/etc. locking the camera onto it.
/:cl: