-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new dummy tablet sprite #5390
base: master
Are you sure you want to change the base?
new dummy tablet sprite #5390
Conversation
What's the |
I didn't even touch that q-q |
Yeah, I never touched that aside from opening it up to check frame change seconds |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things. See picture below comapred to the defibrillator sprite, which shares a color palette.
- Colors (yellow) need to be consistent. In this case I think you should make the body of the sprite and the LCD screen both lighter to match the defib and provide better contrast.
- The outline (blue) should also change in regards to lighting - it should be lighter around the top than the bottom rather than being uniform.
- It looks too flat. You should add more prominent shading around the edges to make the tablet more 3-dimensional. Look at how the CO tablet does it in regards to the lighting towards the top - try something similar.
- The handle (red) is too thin. I think you should make the handle similar to the CO tablet in that it's thicker and sturdier, as well as sharing a color. It would do a lot to make it look more rugged too.
I think it'd look good after these changes are made.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
will merge after sprite freeze |
About the pull request
adds new dummy tablet sprite - medical themed
Explain why it's good for the game
soul and no more CO Tablet skin for Dummy Tablet
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 LTNTS
add: new dummy tablet sprite
/:cl: