Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new dummy tablet sprite #5390

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ItsVyzo
Copy link
Contributor

@ItsVyzo ItsVyzo commented Jan 6, 2024

About the pull request

adds new dummy tablet sprite - medical themed

Explain why it's good for the game

soul and no more CO Tablet skin for Dummy Tablet

Testing Photographs and Procedure

Screenshots & Videos

dreamseeker_mb8nbuL3xy

Changelog

🆑 LTNTS
add: new dummy tablet sprite
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jan 6, 2024
@Birdtalon
Copy link
Contributor

What's the geiger_on sprite that you changed?

@ItsVyzo
Copy link
Contributor Author

ItsVyzo commented Jan 10, 2024

What's the geiger_on sprite that you changed?

I didn't even touch that q-q

@ItsVyzo
Copy link
Contributor Author

ItsVyzo commented Jan 11, 2024

Yeah, I never touched that aside from opening it up to check frame change seconds

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 19, 2024
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things. See picture below comapred to the defibrillator sprite, which shares a color palette.

  1. Colors (yellow) need to be consistent. In this case I think you should make the body of the sprite and the LCD screen both lighter to match the defib and provide better contrast.
  2. The outline (blue) should also change in regards to lighting - it should be lighter around the top than the bottom rather than being uniform.
  3. It looks too flat. You should add more prominent shading around the edges to make the tablet more 3-dimensional. Look at how the CO tablet does it in regards to the lighting towards the top - try something similar.
  4. The handle (red) is too thin. I think you should make the handle similar to the CO tablet in that it's thicker and sturdier, as well as sharing a color. It would do a lot to make it look more rugged too.

I think it'd look good after these changes are made.

image

@github-actions github-actions bot closed this Jan 30, 2024
@nauticall nauticall reopened this Jan 30, 2024
@nauticall nauticall removed the Stale beg a maintainer to review your PR label Jan 30, 2024
@nauticall nauticall marked this pull request as draft January 31, 2024 14:05
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 8, 2024
@github-actions github-actions bot closed this Feb 16, 2024
@ItsVyzo ItsVyzo reopened this Aug 19, 2024
@ItsVyzo ItsVyzo marked this pull request as ready for review August 19, 2024 10:42
@ItsVyzo ItsVyzo requested a review from nauticall August 23, 2024 13:05
@Blundir Blundir added Sprites Approved confirmed no stray pixels Sprites Frozen Merge this and you will make the spritetainers angry. and removed Stale beg a maintainer to review your PR labels Oct 26, 2024
@Blundir
Copy link
Contributor

Blundir commented Oct 26, 2024

will merge after sprite freeze

@Blundir Blundir added the Stale Exempt PR can't go stale label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Frozen Merge this and you will make the spritetainers angry. Sprites Remove the soul from the game. Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants