Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunnels are converted to forsaken on evac #5394

Merged

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Jan 6, 2024

About the pull request

the other half of #5340, fixes #4376
Tunnels are now forsaken!

Explain why it's good for the game

Forsaken xenos should be able to use tunnels

Testing Photographs and Procedure

Open me for testing
Forsaken.Testing.Part.1.mp4
Forsaken.Testing.Part.2.mp4

Changelog

🆑
fix: Tunnels are now converted to forsaken on evac.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 6, 2024
@private-tristan private-tristan marked this pull request as draft January 6, 2024 18:37
@private-tristan private-tristan marked this pull request as ready for review January 6, 2024 22:04
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Birdtalon Birdtalon added this pull request to the merge queue Jan 8, 2024
Merged via the queue into cmss13-devs:master with commit 5525c2b Jan 8, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2024
# About the pull request

Fixes tunnels not showing on the minimap for xenos and observers.
Also fixes tunnels not having forsaken handling unless they were placed
on top of a resin trap.

It was just a small indentation/positioning error in #5394.

# Explain why it's good for the game

ˈfɪksɪz

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

**Before:**

![dreamseeker_ruDebdbg8W](https://github.com/cmss13-devs/cmss13/assets/57483089/61a2c4a7-1c4e-4341-8525-e313b32f45ea)

**After:**

![dreamseeker_fDSFTLzkHW](https://github.com/cmss13-devs/cmss13/assets/57483089/08f31a8e-5f05-4942-a5fb-904e601d689c)


</details>


# Changelog
:cl:
fix: Fixed tunnels not showing on the minimap.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xeno tunnels and eggs are not converted to forsaken
3 participants