refactors sim garbage collection #5395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
harryob
requested changes
Jan 7, 2024
ghost
marked this pull request as ready for review
|
can find the bounds iteratively if requested. At second glance this seems rather excessive, maybe I should just close this xD? Idk. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
refactored the sim garbage collection proc to more effectively clean the sim room. Also added unarmored humans as a potential target mob for the sim.
Explain why it's good for the game
garbage collection should clear the entire area.
Changelog
🆑
add: adds unarmored human mobs as a potential target in the sim.
refactor: refactors sim garbage collection to clear the entire area.
/:cl: