Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databasing whitelists #5402

Merged
merged 30 commits into from
Jan 22, 2024
Merged

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jan 8, 2024

About the pull request

In theory, this should now make whitelists entirely controllable by their senators/the overseer(s) without direct management input.
Major thanks to HarryOB for the major base of this code, all I did is make the UI and some code.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added Whitelist Panel for whitelist senators to manage their own whitelists.
refactor: Whitelist.txt is no longer functional, owing to the new system.
del: Removed "Alien Whitelist" checks regarding base SS13 races.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? UI deletes nanoui/html Feature Feature coder badge Refactor Make the code harder to read labels Jan 8, 2024
code/game/jobs/whitelist.dm Outdated Show resolved Hide resolved
time for bed
code/game/jobs/role_authority.dm Outdated Show resolved Hide resolved
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
code/game/jobs/whitelist.dm Outdated Show resolved Hide resolved
code/game/jobs/whitelist.dm Outdated Show resolved Hide resolved
code/game/jobs/whitelist.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/WhitelistPanel.jsx Outdated Show resolved Hide resolved
@fira fira added the Do Not Тestmerge I will find you and I will testmerge you into the ground if you even think about testmerging this. label Jan 8, 2024
@realforest2001
Copy link
Member Author

Testing with @harryob led to the discovery that SOMETHING in here is causing admin holders to not associate properly. We have no idea why at this time though.

@Nanu308
Copy link
Member

Nanu308 commented Jan 15, 2024

USS Runtime is changed, seems to have added another Z level? @realforest2001

@Nanu308 Nanu308 removed the Mapping did you remember to save in tgm format? label Jan 21, 2024
@harryob harryob added this pull request to the merge queue Jan 22, 2024
Merged via the queue into cmss13-devs:master with commit 6a24a44 Jan 22, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 22, 2024
@realforest2001 realforest2001 deleted the databasing/whitelists branch January 22, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Refactor Make the code harder to read UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants