Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings back UPP Random Names for the UPP Survs. #5414

Closed

Conversation

BadAtThisGame302
Copy link
Contributor

@BadAtThisGame302 BadAtThisGame302 commented Jan 9, 2024

About the pull request

Title.

Explain why it's good for the game

I got inspiration from last round's Trijent Dam's UPP Insert, where I decided to make this PR because UPP with English names is not roleplay friendly or calling someone "Comrade Jeff" or "Master Serzhant Jack" make sense especially because the UPP is meant to disassociate you with your previous character and turn you into a different faction who completely play differently and act differently.

The one thing I guess I can see is that you know if your fellow survivors are bald or not, but that's not really a reason that should be taken into account, realistically. Apart from that I really don't see a positive in having your character name be the UPP Survivors name, unless you RP as a UPP remnant or deserter.

This goes for especially flavor texts that are meant for Marines or for Survs, like "USCM's Greatest Hero" is a flavor text I saw one time on a UPP Survivor, doesn't really make sense does it?

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Brought back the UPP Survivor random name generator for the Trijent Dam UPP Nightmare Insert.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jan 9, 2024
@Birdtalon Birdtalon added Feature Feature coder badge and removed Code Improvement Make the code longer labels Jan 9, 2024
@Steelpoint
Copy link
Contributor

I should note that the reason this was implemented was that the previous head maintainer mandated the change, stating that they believed a player should not have their choice of name taken away from them for a survivor roll. Their preferred change would be if the game offered the player the ability to selecte a non-USCM name for these kinds of roles instead.

@irakligabunia
Copy link
Contributor

"The one thing I guess I can see is that you know if your fellow survivors are bald or not, but that's not really a reason that should be taken into account, realistically. Apart from that I really don't see a positive in having your character name be the UPP Survivors name, unless you RP as a UPP remnant or deserter."
People like playing a character they want to and for that reason I think this PR would be handling the majority because of the minority

@BadAtThisGame302
Copy link
Contributor Author

"The one thing I guess I can see is that you know if your fellow survivors are bald or not, but that's not really a reason that should be taken into account, realistically. Apart from that I really don't see a positive in having your character name be the UPP Survivors name, unless you RP as a UPP remnant or deserter." People like playing a character they want to and for that reason I think this PR would be handling the majority because of the minority

I would be inclined to agree, if not for the completely different faction and the completely different way the UPP is supposed to act from the USCM. Not the mention if you know or hang out with some people and are a UPP surv, they'll talk to you like you are best buds, even though your factions are in a cold war and rarely have fraternization amongst eachother.

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as before, i still would rather we had a box in the "Special Roles" tab in character preferences for UPP names/non-USCM factions. if you need it, i can help out with this

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 27, 2024
@Drulikar Drulikar marked this pull request as draft January 31, 2024 05:16
@github-actions github-actions bot closed this Feb 8, 2024
@BadAtThisGame302 BadAtThisGame302 deleted the upp_name branch February 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants