Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial - Basic Medical Items #5422

Closed
wants to merge 8 commits into from

Conversation

Steelpoint
Copy link
Contributor

@Steelpoint Steelpoint commented Jan 11, 2024

About the pull request

Adds a medical based tutorial aimed at describing every basic medical item a non-Corpsman Marine can access and use, and then describing where they come from and how to store them.

The tutorial goes something like this.

  • Tutorial loads, it begins to showcase every individual basic medical items, stating what they do, this includes bandages, splints, ointment, all kinds of autoinjectors and pill packets
  • Afterwards, the tutorial will showcase the medical pouches, where to get them, and what they come with. It highlights that the injector pouch is unique whereas the other two pouches are free to get from squad vendors.
  • The tutorial ends with letting the player access a generic prep vendor, encouraging the player to experiment with storing medical items, the player can then end the tutorial when they are ready.

Explain why it's good for the game

Educating new players on mechanics is good.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Tutorial describing basic medical items, their uses and where to get them has been added.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jan 11, 2024
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things I've noticed from a brief scan. You also need to make sure you include your new .dm file in the .dme
I will try to have a proper look at this soon.

code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
code/datums/tutorial/marine/medical_basic_item.dm Outdated Show resolved Hide resolved
@Steelpoint
Copy link
Contributor Author

requested changes made

Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good overview of standard medical and the code is good.

Although I personally thought that the pacing might be a little too fast for a new player when describing what the items are.

I also managed to break your tutorial somehow by softlocking myself at the stage where the player has to vend a pull packet pouch and there wasn't any to vend.
dreamseeker_2024-01-13_14-28-55

I would like to see a little work on the pacing though so it doesn't feel like information overload and we actually get the player to use more of the items and do stuff within the tutorial. Explain an item or two, then get the player to use them for themselves and see how they work- then move onto the next. The existing medical tutorial is a good example. This will be more memorable to a player and will flow more easily into the next tutorial and so on and so on.

I'll let you have a think about this and mark your PR as ready for review when you're ready.

addtimer(CALLBACK(src, PROC_REF(pouch_ten)), 6 SECONDS)

/datum/tutorial/marine/medical_basic_item/proc/pouch_ten()
message_to_player("It will be up to you to figure out which of these you should take. You can consider using these pouches, or placing some of them in your satchel/backpack.")
Copy link
Contributor

@Birdtalon Birdtalon Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played your tutorial and this reads as though you can place the pouch itself into your satchel which it's too big for.

@Birdtalon Birdtalon marked this pull request as draft January 13, 2024 14:37
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 21, 2024
@Steelpoint
Copy link
Contributor Author

I'll reopen once I've got free time to work out the PR and make changes, just closing to stop the auto-close

@Steelpoint Steelpoint closed this Jan 21, 2024
@Steelpoint Steelpoint deleted the BasicMedTutorial branch July 17, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants