New minimap update sound #5429
Merged
New minimap update sound #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Sound
|
According to audacity this sound should be hovering around the -12db range. FWIW. |
|
Could you cite the source of the sound please? |
|
Sure thing, full creative commons availability: https://freesound.org/people/NebulousRoyale/sounds/346112/ |
harryob
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Replaces the Morse Code sound for minimap updates with another data stream sound.
Explain why it's good for the game
sos-morse-code.ogg is used in a LOT of places. Having a unique "hey your minimap was updated" sound is beneficial because it informs you that something has changed that isn't some of the many already used updates that people may not care about.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
soundadd: added unique sound for minimap updates
/:cl: