Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abomination rework and predator plasma rifle buff. #5432

Merged
merged 88 commits into from
Feb 22, 2024

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented Jan 12, 2024

About the pull request

This pr intends to catch up predalien towards current gameplay by reworking a few abilities and adding new ones.

Explain why it's good for the game

Currently the predalien has been untouched (practically) for over 3-4 years now, while being rare and decent enough to hold its own against current year marines and predators, its highly outdated. It's main power being "the gib" which is not fun for marines to be instantly removed from the game as most of the time you will be accompined by a queen and the entire hive. its not being fun being comboed into a queen screech + gib

As their natural counter, the predators are currently lacking in a strong way to counter it, i believe the Plasma Rifle thats only available when an abomination is present is very weak, underpowered and generaly not that good. I can go into deeper details if anyone wants me to. So my natural response was to make it set people on fire because generally the predalien will be guarded by an entire hive. This will make it so that atleast the xenomorph hit, will have to back off allowing the predator to breathe. I havent touched the recharge rate because i think this incin bullet will be powerful enough to compensate for the low recharge rate, and only 16 shots (you need 14 dead on shots to kill an abomination, not counting its movement, phermones, and the entire hive guarding it.)

below are all the changes ive decided to make;
"Feral Frenzy" is a mashup of the old gut ability, it now has a toggle that lets you choose between AOE/SINGLE TARGET. I think this is a defining factor in predalien reworks, because currently it is too focused on fighting predators and not enough on marines. This will help you fend off against a marine group by letting you become devastating against grouped up marines. Or chosing to catch one by switching to single target since it has a root. (Also retaining its ability to fight off predators).

"Feral Rush"; Feral rush incrases your armor and speed by a certain number, i wanted to add this instead of the useless pounce as i felt like the pounce was basically not providing you with anything other then just a distance closer, and it didnt fit in with the new gutting abilities, this way you can speed up, armor up and then go inside the marine force and do your aoe ability and get back out. This will ensure that you arent useless while going in since without the armor and speed, you will melt by the time you go in marine numbers, (also remember the AOE gut has a windup of 2 seconds.), The armor is removed 6 seconds after the slow (the speed lasts 3 seconds, so you're just armored for an extra 3 seconds) as to have that extra armor while retreating from more open places.
"Stomp" ; the reason ive decided to remove this ability is it felt way out of place for this kit and just simply wasnt good enough (in my opinion) to being there although a slow or aoe root might be needed if this gets approval enough for gametesting.

"Frenzy Smash" ; Grabs somebody by the leg and smashes them to the ground, this honestly just felt like a cool ability to add, it lets you keep somebody in place but also keep them moving, this is mostly a flair ability but still VERY deadly, may be buffed to make preds slower for a duration. deals 20 damage and scales with kills

THIS IS ALL UP FOR DEBATE, AND I WOULD LIKE TO WATCH THIS ALL INGAME VIA ABOM EVENTS BY ADMINS IF THATS POSSIBLE.

Testing Photographs and Procedure

Screenshots & Videos
predalienaoe.mp4
predalienrush.mp4
predaliensmash.mp4

Changelog

🆑
add: Added a new ability to the predalien "Feral Rush" that increases it's armor and speed for a short duration.
add: Added two new abilities to the predalien "Feral Frenzy" and a toggle. The predalien can now switch between a single target GUT and an AOE one, both of which has damage that scale with your kills.
del: Removed the predaliens gib ability
del: Removed the predaliens "pounce" ability
del: Removed the predaliens "Ground Smash" ability
balance: Predalien no longer has plasma costs, or plasma.
balance: The Plasma Rifle, which is ONLY used to hunt abominations now has a higher ROF and has incin bullets.
spellcheck: Re-wrote the predalien text to be more up to date and remove missinformation
qol: Everyone can see how many kills the predalien has by examining it.
add: Added a "Feral Smash" ability that lets you grab somebody and smash them to the ground, this scales with kills and is a devastating attack.
balance: Removed screenshake from predalien's screech
balance: Predalien removes fire stacks faster.
fix: Girders are now slashable by very_sharp_claws instead of just having a queen chack
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Removal snap Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Jan 12, 2024
@Red-byte3D Red-byte3D changed the title Abomination rework and predator plasma rifle buff. (WIP) Abomination rework and predator plasma rifle buff. Jan 12, 2024
@Red-byte3D Red-byte3D marked this pull request as ready for review January 12, 2024 17:17
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay we're halfway there. Please have a little think about your code especially when copy pasting from other areas and try to understand why you're doing certain things.

For example, your predalien uses no plasma but there are checks for using plasma in here.

Also have a think about how this can be cleaned up a bit, tidy up some duplicated code, and where and importantly why you're doing your checks such as check_state().

@Birdtalon Birdtalon marked this pull request as draft January 12, 2024 19:32
@Red-byte3D Red-byte3D marked this pull request as ready for review January 12, 2024 23:15
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments.

@Birdtalon Birdtalon marked this pull request as draft January 14, 2024 15:16
@Drulikar Drulikar added the Needs Testing Need to test it on the guinea pigs (production server) label Feb 18, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs testing in game now.

cm13-github added a commit that referenced this pull request Feb 18, 2024
@kooarbiter

This comment was marked as off-topic.

cm13-github added a commit that referenced this pull request Feb 18, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Feb 18, 2024

As is this has balance approval. I wouldn't mind it being a little stronger though either. But if you're happy with it as is; I can just piggyback some of the xeno end game buffs to an abom spawn later.

As for the plasma rifle, that seemed to do well. Largely causes xenos to either throw them selves and die by being aggressive and ignoring the fire, or for them to withdraw to resist/pat.

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 18, 2024
cm13-github added a commit that referenced this pull request Feb 19, 2024
@Drulikar Drulikar marked this pull request as draft February 20, 2024 09:08
cm13-github added a commit that referenced this pull request Feb 20, 2024
@Drulikar
Copy link
Contributor

Drafted while you're implementing fire resist speed and girder damage fix

@Red-byte3D Red-byte3D marked this pull request as ready for review February 20, 2024 12:09
cm13-github added a commit that referenced this pull request Feb 21, 2024
cm13-github added a commit that referenced this pull request Feb 21, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 22, 2024
Merged via the queue into cmss13-devs:master with commit dc412e4 Feb 22, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Feb 22, 2024
@Red-byte3D Red-byte3D deleted the predandpredalienstuff branch April 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Needs Testing Need to test it on the guinea pigs (production server) Removal snap Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants