Defines cleanup #5439
Merged
Defines cleanup #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace Clamp() define with native clamp() function
replace Tan() define with native tan() function
replace roundNearest() define with native round(x, 1) function
replace CEILING(x, 1) use with simpler Ceiling() define, in 515 all Ceiling() use can be replaced by native ceiling()
replace FLOOR(x, 1) use with simpler Floor() define, in 515 all Floor() use can be replaced by native floor()
pulls out of projectile code and changed to a more robust version, copied from TGMC: https://github.com/tgstation/TerraGov-Marine-Corps/blob/2da5c237640d73e3e66ad79e34861e9682f4609c/code/__DEFINES/maths.dm#L87-L90
replace n_ceil() use with Ceiling() define
harryob
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Cleans up some duplicate, unused, and/or obsolete (due to native DM implementation) defines. Each change is isolated in its own commit if any are objectionable.
Clamp()- functionally identical to and replaced by nativeclamp(), introduced in 513: https://www.byond.com/docs/ref/#/proc/clampTan()- functionally identical to and replaced by nativetan(), introduced in 513: https://www.byond.com/docs/ref/#/proc/tanroundNearest()- functionally identical to and replaced by native 2-argumentround(x, 1): https://www.byond.com/docs/ref/#/proc/roundIsInRange()- never used and identical toISINRANGE()define, elected to keep the latter as it is in the DEFINES folderCEILING(x, 1)- when 1 is the second argument, replaced by the functionally identical and simplerCeiling()define, which itself can be replaced by nativeceil()when we move to 515: https://www.byond.com/docs/ref/#/proc/ceiln_ceil()- functionally identical to and replaced byCeiling()FLOOR(x, 1)- when 1 is the second argument, replaced by the functionally identical and simplerFloor()define, which itself can be replaced by nativefloor()when we move to 515: https://www.byond.com/docs/ref/#/proc/floorLERP()- a version was implemented in projectile code, moved it out to the DEFINES folder and switched to a slightly more robust version from TGMC: https://github.com/tgstation/TerraGov-Marine-Corps/blob/2da5c237640d73e3e66ad79e34861e9682f4609c/code/__DEFINES/maths.dm#L87-L90Explain why it's good for the game
Less duplication leads to greater maintainability.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
No player-facing changes.