Fixes larvae sometimes spawning in space #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jan 15, 2024
Birdtalon
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes larvae sometimes spawning in space on Fiorina. (And any other space-based maps)
I think this is being caused by the
do_buried_larva_spawn()proc looking for any/turf/opensubtypes in range, but not performing any checks on them.Explain why it's good for the game
Occasionally at roundstart on Fiorina a larva will spawn outside of the station's walls in space, and need an admin to teleport them back inside. Although it is pretty funny when it happens, it's probably best to fix it.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Fixed larvae sometimes spawning in space on Fiorina.
/:cl: