Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Autoname change #5456

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jan 15, 2024

About the pull request

Makes autonaming cameras happen based on a preset variable rather than hardcode.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Security camera autoname is now determined by a variable rather than hardcode.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jan 15, 2024
code/game/machinery/camera/camera.dm Outdated Show resolved Hide resolved
code/game/machinery/camera/camera.dm Outdated Show resolved Hide resolved
code/game/machinery/camera/camera.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft January 18, 2024 15:30
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 18, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 19, 2024
@realforest2001 realforest2001 marked this pull request as ready for review January 22, 2024 11:31
@Birdtalon Birdtalon added this pull request to the merge queue Jan 28, 2024
Merged via the queue into cmss13-devs:master with commit e143889 Jan 28, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 28, 2024
@realforest2001 realforest2001 deleted the forest/autonamecam branch March 29, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants