Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to reduce the number variable using colour in them instead of color. #5472

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jan 16, 2024

About the pull request

another PR to reduce the number of time colour is being used for variables.

did some change of comment to be to standard format too.

left with 54 instance of colour in 15 differents files. most that is left have color var that could create conflit so i would rather do in a seperate PR later.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: refactor to reduce the number variable using colour in them instead of color.
/:cl:

…e cleaning on some files.

left with 54 instance of colour in 15 differents files.
most that is left have color var that could create conflit so i would rather do in a seperate PR later.
@github-actions github-actions bot added the Refactor Make the code harder to read label Jan 16, 2024
@Huffie56 Huffie56 marked this pull request as ready for review January 16, 2024 16:51
@harryob harryob added this pull request to the merge queue Jan 18, 2024
Merged via the queue into cmss13-devs:master with commit ac9a7e6 Jan 18, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Jan 18, 2024
@Huffie56 Huffie56 deleted the some_more_colour_color branch January 19, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants