Defender crest balloon alert (plus consistent centring) #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
harryob
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds balloon alerts to the Defender's 'Toggle Crest Defense' ability.
Also a tiny refactor to make balloon alerts always be centred above the source atom's sprite, the same way runechat/langchat does it. (I can split this part off into a separate PR if necessary.)
Explain why it's good for the game
There is already a sprite change when toggling the crest, but it can sometimes be difficult to notice when you're not facing to the side.
Testing Photographs and Procedure
Screenshots & Videos
Before:
dreamseeker_P5zLiYfcyS.mp4
dreamseeker_uromouIhSm.mp4
(Obviously the defender text wasn't there before this PR, but just for demonstration purposes.)
After:
dreamseeker_XydYnPIQUg.mp4
dreamseeker_xIBeO0XBY5.mp4
Changelog
🆑
add: Added a 'balloon alert' when toggling Crest Defense as a Defender.
code: Made balloon alerts centre themselves on xeno sprites.
/:cl: