Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m56d and m2c crushing, labeling, and damage retention #5481

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jan 17, 2024

About the pull request

This PR addresses 5 things regarding the m56d and m2c:

  1. Both now properly retain labeler labels (though technically the m56d post can lose its label - gun takes priority)
  2. The m56d now retains its damage when disassembled
  3. The m56d's post now has an implementation for handle_charge_collision so they can croosh not fully assembled guns
  4. It appeared possible to duplicate the m56d when a charger crushed it if it both was destroyed by the impact and the update_health resulted in the gun being refunded; this is no longer possible since the charge logic returns early if it is destroyed
  5. Vehicles running over a m56d post now undeploys the m56d correctly if it had a gun attached (it would downgrade to just a post)

Explain why it's good for the game

Fixes #5477 but I don't think this ever worked. Rather the issue is purely when the gun is in this state:
image

Additionally, if we're going to have a mechanic to weld to fix the gun; you shouldn't be able to circumvent this by simply disassembling it... However, since the destruction of the m56d didn't have a guaranteed chance to destroy the gun, technically this results in a fully repaired gun again if you can make another post for it. It would need to work more like the m2c if we wanted it to remain in a broken state in this situation.

Testing Photographs and Procedure

https://youtu.be/rg1mLFjhsEY (though I forgot to record crowbar disassembly for the m56d too)

Changelog

🆑 Drathek
fix: The M56D and the M2C now retain their labels when disassembled
fix: The M56D can now be charger crushed when not fully assembled
fix: The M56D being run over by a vehicle now undeploys the gun correctly (so it retains the gun if it had a gun)
fix: Fix an edge case that could duplicate the M56D when charger crushed
balance: The M56D now retains the health of the gun through all of its different disassembled states
/:cl:

Implement crusher collision for m56d_post
@github-actions github-actions bot added Fix Fix one bug, make ten more Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jan 17, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

@harryob harryob marked this pull request as draft January 18, 2024 15:31
@Drulikar Drulikar marked this pull request as ready for review January 19, 2024 11:10
@harryob harryob added this pull request to the merge queue Jan 19, 2024
Merged via the queue into cmss13-devs:master with commit 2442f89 Jan 19, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 19, 2024
@Drulikar Drulikar deleted the Fix_m56d_m2c branch January 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M56Ds inmune to crusher charge
2 participants