Fix spicy weed_food fires #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR adds a signal response to prevent pre-ignition if the mob is merged with weeds and also extinguishes the mob when they begin merging. Usually in this state the weeds will simply burn away and then another tick will then ignite the un-merged mob, but apparently there were weird edge cases where the mob would be ignited on weeds.
Because its a weird scenario I am not 100% certain I have solved the issue (as in I can't guarantee what ignited the mob calls and respects the signal if the extinguish call when merging isn't enough), but I am almost certain what I have done should hit most if not all scenarios that made this possible.
Explain why it's good for the game
Fixes #5483
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Fixed mobs merged with weeds remaining ignited
/:cl: