-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faxpansion - Adds TWE/UPP/CLF Channels to Fax Life #5508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra bits which wouldn't really fit on discord:
Co-authored-by: SabreML <[email protected]>
Co-authored-by: SabreML <[email protected]>
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faxes seem to be working with the exception of an existing bug:
-
Please fix the admin -> fax machine press messages getting added to the USCM pool instead of the press pool in topic.dm line 1166 inside
else if(href_list["PressFaxReply"])
incorrectly hasGLOB.USCMFaxes.Add(
... -
Also do you mind changing clfaxreply to wyfaxreply? its really confusing with clffaxreply
will do, just lemme make some time |
About the pull request
Adds TWE/UPP/CLF stamps to paper.dmi
Adds TWE/UPP/CLF faxes to network
Explain why it's good for the game
More roleplay opportunities and more staff options
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 LTNTS
imageadd: stamp sprites for TWE, UPP and CLF
code: added TWE, UPP and CLF channels
/:cl: