Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faxpansion - Adds TWE/UPP/CLF Channels to Fax Life #5508

Merged
merged 9 commits into from
Feb 3, 2024

Conversation

ItsVyzo
Copy link
Contributor

@ItsVyzo ItsVyzo commented Jan 20, 2024

About the pull request

Adds TWE/UPP/CLF stamps to paper.dmi
Adds TWE/UPP/CLF faxes to network

Explain why it's good for the game

More roleplay opportunities and more staff options

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 LTNTS
imageadd: stamp sprites for TWE, UPP and CLF
code: added TWE, UPP and CLF channels
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Code Improvement Make the code longer labels Jan 20, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra bits which wouldn't really fit on discord:

code/modules/admin/tabs/event_tab.dm Outdated Show resolved Hide resolved
code/modules/admin/tabs/event_tab.dm Outdated Show resolved Hide resolved
code/modules/admin/tabs/event_tab.dm Outdated Show resolved Hide resolved
@ItsVyzo ItsVyzo marked this pull request as ready for review January 21, 2024 04:03
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 29, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Faxes seem to be working with the exception of an existing bug:

  • Please fix the admin -> fax machine press messages getting added to the USCM pool instead of the press pool in topic.dm line 1166 inside else if(href_list["PressFaxReply"]) incorrectly has GLOB.USCMFaxes.Add(...

  • Also do you mind changing clfaxreply to wyfaxreply? its really confusing with clffaxreply

@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jan 31, 2024
@ItsVyzo
Copy link
Contributor Author

ItsVyzo commented Jan 31, 2024

image

Faxes seem to be working with the exception of an existing bug:

  • Please fix the admin -> fax machine press messages getting added to the USCM pool instead of the press pool in topic.dm line 1166 inside else if(href_list["PressFaxReply"]) incorrectly has GLOB.USCMFaxes.Add(...
  • Also do you mind changing clfaxreply to wyfaxreply? its really confusing with clffaxreply

will do, just lemme make some time

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jan 31, 2024
@Drulikar Drulikar marked this pull request as draft February 1, 2024 18:31
@ItsVyzo ItsVyzo marked this pull request as ready for review February 2, 2024 11:42
@ItsVyzo ItsVyzo requested a review from Drulikar February 2, 2024 11:42
@Drulikar Drulikar added this pull request to the merge queue Feb 3, 2024
Merged via the queue into cmss13-devs:master with commit d28658c Feb 3, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Feb 3, 2024
@ItsVyzo ItsVyzo deleted the faxExpand branch February 3, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants