Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : turning newscasters into "props" #5522

Merged
merged 12 commits into from
Feb 9, 2024
Merged

refactor : turning newscasters into "props" #5522

merged 12 commits into from
Feb 9, 2024

Commits on Jan 22, 2024

  1. so turn the newcaster into basicly a prop 

    fallowing what TGMC did there
https://github.com/tgstation/TerraGov-Marine-Corps/blob/master/code/game/objects/machinery/newscaster.dm
    Julien committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    352dbe6 View commit details
    Browse the repository at this point in the history

  2. apparently i need to put back those here... if we don't want code to … 

    …die.

because for some reason some datum that is used in multiple files is declared on newscaster.dm
sureeeeeeeeeeeeeeeeeeeeeee
    Julien committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c1b7aa9 View commit details
    Browse the repository at this point in the history

  3. i need to be more carrefull with those let's put back all the datum b… 

    …ack in....
    Julien committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6a953a3 View commit details
    Browse the repository at this point in the history

  4. apparently those two global list and datum where in used my bad....

    Julien committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    706d8bd View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. moved all the datum and global to economy_misc.dm 

    since they are no longer in use here.
massive cleanup of newscaster file...
    Julien committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    06c4322 View commit details
    Browse the repository at this point in the history

  2. deleting two stuff that wasn't use in the code plus deleted comment o… 

    …ut stuff...
    Julien committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b7023e4 View commit details
    Browse the repository at this point in the history

  3. finaly clean up and comment let's see if it work...

    Julien committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    8af6729 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into newscaster.dm

    @Huffie56
    Huffie56 authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    5290610 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. deleting stuff see what happen

    Julien committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9a9de76 View commit details
    Browse the repository at this point in the history

  2. deleted more stuff from newscaster

    Julien committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ac120ab View commit details
    Browse the repository at this point in the history

  3. this seem to be link to newscaster

    Julien committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d64f927 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into newscaster.dm

    @Huffie56
    Huffie56 authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    891b87c View commit details
    Browse the repository at this point in the history