Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scout ammo and economy nerf #5539

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented Jan 24, 2024

About the pull request

This pr aims to make high impact and incindeary mags rarer.

Explain why it's good for the game

Currently you get 5 mags per req buy, which is while normally not alot for any other weaponhigh impact rounds can bascially stun anything thats a stunnable caste.
Having this easy access to this many mags is a bit broken in my opinion. I dont think this nerf will make scout useless, but it will definetly make you rethink where and how you use your ammo. Which in my opinion is important when you can solo juggle 3 xenomorphs alone.

I didnt think touching the actual cost of the crates were important as the 2 mag removal should really make a difference and make your special ammo feel special and rarer.

I also decided to not change the numbers on the normal bullets because i think they're already not that great, and have instead decided to remove the ARMOR_PENETRATION_TIER_10 (which equals to 50 ARMOR PIERCE ??) from HIGH IMPACT ROUNDS and change it to 10 ap instead.I dont think it needs that much ap, especially since your main combo is incin round into stun mag. This should help armored caste feel like they arent instantly dying to the stun gun.

I've decided to buff the damage of the normal mags to 60 from 55, while i dont think it will make the mags BETTER then other options, it will certainly give it a chance to deal with tier threes so you arent constantly locked to the backline, alongside its 35 AP.

Testing Photographs and Procedure

Changelog

🆑
balance: Scout specialist incin/high impact mag crates now only has 3 instead of 5
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jan 24, 2024
@HeresKozmos

This comment was marked as off-topic.

@wgtjunior743

This comment was marked as off-topic.

@Red-byte3D

This comment was marked as off-topic.

@wgtjunior743

This comment was marked as off-topic.

@Red-byte3D

This comment was marked as off-topic.

@GoldenDarkness55

This comment was marked as off-topic.

@wgtjunior743

This comment was marked as off-topic.

@Steelpoint
Copy link
Contributor

Steelpoint commented Jan 29, 2024

For accuracy of information the change to Impact AP will have the denoted changes on the following T1 and T2 xenos regrading shots to crit. I've not accounted for T3 xenos, but T3s are far harder to kill now as well. Any xeno not mentioned already has no or insufficient armour to make a difference.

Defender

  • PreNerf - 13 Shots
  • PostNerf - 34 Shots

Warrior

  • PreNerf - 13 Shots
  • PostNerf - 17 Shots

Lurker Vampire

  • PreNerf - 10 Shots
  • PostNerf - 13 Shots

Spitter

  • PreNerf - 14 Shots
  • PostNerf - 16 Shots

Burrower

  • PreNerf - 13 Shots
  • PostNerf - 25 Shots

@Steelpoint
Copy link
Contributor

Also, changelog is incorrect, it states that impact ammo has been lowered to 15 AP but it has in fact been lowered to 10 AP. PR title should also reflect this is changing the damage and armour pen values of the scouts weapons as well as changing the economy of its acquisition

@harryob
Copy link
Member

harryob commented Jan 29, 2024

balance discussion is still not happening on github, take it to the forums or discord

@Red-byte3D
Copy link
Contributor Author

Also, changelog is incorrect, it states that impact ammo has been lowered to 15 AP but it has in fact been lowered to 10 AP. PR title should also reflect this is changing the damage and armour pen values of the scouts weapons as well as changing the economy of its acquisition

should be 15 i mightve forgot to push a commit

@Red-byte3D Red-byte3D changed the title scout ammo economy nerf scout ammo and economy nerf Jan 29, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 6, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the damage numbers or penetration need to be changed at this time. However I am fine with a reduction in how many mags the scout has access to at round start. Please revert the pen and dmg changes and just keep your magazine amount changes. Ultimately I would like everything to have an increased reliance on req keeping them supplied.

@Drulikar Drulikar marked this pull request as draft February 6, 2024 17:37
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Feb 6, 2024
@Red-byte3D Red-byte3D marked this pull request as ready for review February 6, 2024 21:05
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the names of the crates:
image

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 6, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 6, 2024
Merged via the queue into cmss13-devs:master with commit 867f7e2 Feb 6, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 6, 2024
HaultyAnonie added a commit to HaultyAnonie/cmss13 that referenced this pull request Feb 18, 2024
@Red-byte3D Red-byte3D deleted the scoutnerf branch April 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants