Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadchat no longer gets notified about tutorial facehuggers #5546

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Jan 24, 2024

About the pull request

Deadchat will no longer get notified about any facehugs inside a tutorial area.

This is the best solution I can think to this problem, an alternative being checking the hive of the facehugger and canceling based on that. Recommendations are welcome.

Explain why it's good for the game

Tutorials are irrelevent to the main game, and players shouldnt be notified that someone is using the tutorial system.

Testing Photographs and Procedure

Screenshots & Videos ![image](https://github.com/cmss13-devs/cmss13/assets/91113370/755baecd-b727-4105-ae4b-32c17aa510ff)

No dchat message.

Changelog

🆑
fix: Dchat is no longer notified of hugs from tutorials
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 24, 2024
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to check the hivenumber of the hugger please.

@Birdtalon Birdtalon marked this pull request as draft January 25, 2024 10:52
@Contrabang Contrabang marked this pull request as ready for review January 26, 2024 00:51
@Drulikar Drulikar added this pull request to the merge queue Jan 26, 2024
Merged via the queue into cmss13-devs:master with commit a6f732c Jan 26, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 26, 2024
@Contrabang Contrabang deleted the tutorial-hugger branch January 26, 2024 20:44
@Zonespace27 Zonespace27 added this to the Tutorials milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants