Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : turn some "# and use the proper define from colour.dm for 21 files. #5553

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jan 25, 2024

About the pull request

small PR...

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: turn some "# and use the proper define from colour.dm for 21 files.
/:cl:

@github-actions github-actions bot added the Refactor Make the code harder to read label Jan 25, 2024
@Huffie56 Huffie56 marked this pull request as ready for review January 25, 2024 21:05
@Huffie56 Huffie56 marked this pull request as draft January 25, 2024 21:06
@Huffie56 Huffie56 marked this pull request as ready for review January 25, 2024 23:09
@Huffie56
Copy link
Contributor Author

thanks harry

@harryob harryob added this pull request to the merge queue Jan 30, 2024
Merged via the queue into cmss13-devs:master with commit b27c024 Jan 30, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 30, 2024
@Huffie56 Huffie56 deleted the define_colour.dm branch January 30, 2024 14:19
github-merge-queue bot pushed a commit that referenced this pull request Feb 3, 2024
….dm for 21 files." (#5626)

Reverts #5553
# About the pull request
Revert because some files are case sensitive and i did those change on a
bunch of them so better remove it all.
it wasn't an important PR anyway...
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
# Testing Photographs and Procedure
i tested welding different different cades at the same time seem to work
i had some weirdness but it's working.
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: revert PR #5553 as it is causing issues with color on atmo pipe.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Make the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants