Food processor can be used to remove carpotoxin and acidic blood with master domestic skill #5577
Conversation
Characters with master domestic skill (currently MST and synthetic) can process carp and xenomeat to remove carpotoxin and acidic blood.
To accompany the processor ability to remove carpotoxin, all carpotoxin is present in carp fillets rather than carp fillets with extra added in recipes.
To accompany the processor ability to remove acidic blood, all acidic blood is present in xenomeat rather than xenomeat with extra added in recipes.
github-actions
bot
added
Feature
|
Why have the unique typechecking in it? why not have the output lead to a processed variant with all your wanted changes in it, instead of modifying a copy of the original |
The process proc now uses the made_from_player variable to discern if a name change is necessary. Additionally, the recipes now refer to new types to avoid changing reagents in process.
Sorry; it's been a fair while since I last touched DM. Yeah, that's a good shout. I've redone it to refer to processed versions in the recipes. Rather than checking istype, it'll look for the made_from_player variable to carry the name (which has the added benefit of keeping a person's name for meatballs made in the processor, which in turn affects meatball derived recipes). Thank you for pointing that out. Is there a more efficient way I could be checking for the variable I'm looking for now? |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
| src.bitesize = 6 | ||
|
|
||
| /obj/item/reagent_container/food/snacks/meat/xenomeat/processed | ||
| name = "meat" |
There was a problem hiding this comment.
Just to check: did you want to change the name of this to "processed meat" like on the carp fillet, or have only the description be different?
There was a problem hiding this comment.
I wasn't sure of an elegant way to have it called processed NAME meat (e.g. processed Queen meat) so opted to just have it as NAME meat, which is handled in process (which, as an added bonus, will keep a person's name if they get turned into meatballs). To my ears, "NAME processed meat" feels off but happy to take that approach if it'd be better.
There was a problem hiding this comment.
Hm.. It could be done by refactoring how the made_from_player variable is handled, but that might be out of the scope of the PR.
Either way, this works fine as it is now IMO. 👍
About the pull request
This PR makes it so that characters with master level domestic skill are able to remove carpotoxin and acidic blood from carp fillets and xenomeat. Xenomeat, carp fillets and recipes including those have had their levels adjusted to avoid adding additional carpotoxin/xenoblood when creating a recipe so a processed ingredient won't result in a dangerous recipe.
I've tested this using characters with and without the skill with flour, potatoes, xenomeat and carp fillets to ensure that only the affected processor uses are changed, that processing works correctly and that the skill is required.
Explain why it's good for the game
This would open more opportunities for the mess technician to serve the crew with recipes that rarely see the light of day due to being dangerous (while leaving some risk if an MST forgets to process the ingredients). Some marine players might also enjoy the roleplay opportunities around getting the chef to turn their fallen enemies into burgers.
Testing Photographs and Procedure
Screenshots & Videos
Here is shown a character with insufficient skill unable to modify the food, before putting it in the soda fountain to show its reagents:
https://github.com/cmss13-devs/cmss13/assets/32908370/8138d1c5-77a2-4f7d-92e9-9d7059fa3f05
Here is shown a character with sufficient the skill able to modify the food, before putting it in the soda fountain to show its reagents:
https://github.com/cmss13-devs/cmss13/assets/32908370/93bb0c99-fccf-46ca-a786-579be203629b
Changelog
🆑
add: Increased levels of acidic blood and carpotoxin in xenomeat and carp fillets.
del: Xenomeat and carp fillet-based recipes no longer add additional acidic blood or carpotoxin.
qol: Master level domestic skill allows the use of the food processor to remove acidic blood and carpotoxin from xenomeat and carp fillets.
fix: Turning named pieces of human meat into meatballs will retain the human's name.
/:cl: