Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow surgery on crashed ships (and new tile variants allowing surgury & construction) #5579

Merged
merged 43 commits into from
Feb 1, 2024
Merged

Allow surgery on crashed ships (and new tile variants allowing surgury & construction) #5579

merged 43 commits into from
Feb 1, 2024

Conversation

hislittlecuzingames
Copy link
Contributor

@hislittlecuzingames hislittlecuzingames commented Jan 28, 2024 •
edited by Drulikar
Loading

About the pull request

following quote outdated...

I INSTANCE edited the turfs/floor tiles for the nightmare inserts for:
Solar (Big Red)
Desert Dam

I edited the files to:
Supports_surgery 1
(enabled surgury. Default value is 0)

made proper new tiles and replaced in many map files & nightmare inserts

Explain why it's good for the game

Allows people to fucking DO SURGURY!
Literally ruined someone's entire round because I couldn't fix his IB and by the time I did, 4 T3 were there and he got got.

Testing Photographs and Procedure

Start at 1:10. I fixed that other tile variant not allowing surgury at the end of the video.

DW, reverted CC map file changes for my testing tiles.
https://youtu.be/cXLck9H_t8U

Changelog

🆑
balance: Nightmare inserts of crashed ships on Solaris (big red) and Desert dam can do surgury in them INSTANCE EDIT
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Quality of Life Make the game harder to play labels Jan 28, 2024
@Birdtalon
Copy link
Contributor

Didn't do any testing.

I heard instance editing can break stuff.
I'm making the PR now anyway incase it's known that this change won't break stuff.
If it doesn't work it can be reverted.

That's not how we work here. Please undraft your PR once you have tested it.

@Birdtalon Birdtalon marked this pull request as draft January 28, 2024 10:08
Birdtalon
Birdtalon previously requested changes Jan 28, 2024
View reviewed changes
code/__DEFINES/__game.dm Outdated Show resolved Hide resolved
Zonespace27
Zonespace27 previously requested changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change your PR title to something more descriptive.

code/game/turfs/open.dm Outdated Show resolved Hide resolved
code/game/turfs/open.dm Outdated Show resolved Hide resolved
code/game/turfs/open.dm Outdated Show resolved Hide resolved
maps/map_files/Ice_Colony_v2/Ice_Colony_v2.dmm Show resolved Hide resolved
@hislittlecuzingames hislittlecuzingames changed the title Allow surgery on crashed ships Allow surgery on crashed ships (and new tile variants allowing surgury & construction) Jan 28, 2024
@hislittlecuzingames
Copy link
Contributor Author

Did big refactor of tiles.

Didn't rename because of...
#5579 (comment)
above linked question.

@hislittlecuzingames
Copy link
Contributor Author

hislittlecuzingames commented Jan 28, 2024 •
edited
Loading

I believe ALL changes are up to standard.

Please review.

Nanu308
Nanu308 reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jan 30, 2024
@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. and removed Quality of Life Make the game harder to play labels Feb 1, 2024
@Drulikar Drulikar dismissed stale reviews from Birdtalon and Zonespace27 February 1, 2024 08:09

Resolved

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 1, 2024
Drulikar
Drulikar approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine.

Just for clarity though, any interiors that are ever going to be actually moving should not be allowed to have surgery.

@Drulikar Drulikar added this pull request to the merge queue Feb 1, 2024
Merged via the queue into cmss13-devs:master with commit 357e3d1 Feb 1, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 1, 2024
@cm13-github
Automatic changelog for PR #5579 [ci skip]
63d73a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanu308 Nanu308 Nanu308 left review comments

@Drulikar Drulikar Drulikar approved these changes

@Zonespace27 Zonespace27 Awaiting requested review from Zonespace27

@Birdtalon Birdtalon Awaiting requested review from Birdtalon

Assignees
No one assigned
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hislittlecuzingames @Birdtalon @Zonespace27 @Nanu308 @Drulikar