XM4 Armor Integral Motion Detector

[MobiusWon]

About the pull request

Adds a motion detector action to the XM4 Intelligence Officer (IO) Armor.

Explain why it's good for the game

1. Currently there is no difference between the standard M4 "RTO" armor and the XM4 IO armor. The integral motion detector makes the X for "Experimental" meaningful.
2. The XM4 currently goes mostly unused by IOs, this would change that.
3. The Motion Detector is already an essential item for IOs, this change distinguishes it from the other armor choices in game and adds a uniqueness to their piece of kit.
4. I envision the XM4 as the "safety" choice for IOs: it has extra storage, slower, and (with this feature) includes a Motion Detector to improve situational awareness. The other common choices for IOs are the Service Jacket I.E. the "speed" choice, and the M3-L armor a "middle ground" option.
5. This should not have any meaningful impact on balance vs. skirmishers as the Motion Detector is already an essential item for IOs.
6. Keep in mind the XM4 is only attainable by IOs and cannot be worn or purchased by anyone else.

NOTE: This is my first "major" feature. I am open to suggestions, including "balance" related stuff.

Testing Photographs and Procedure

XM4.Motion.Detector.Test.mp4

Edit: Tested to confirm that the MD turns off upon user death. ✔️

Changelog

🆑
NervanCatos
add: Adds integral Motion Detector to XM4 IO Armor
balance: Uniform utility accessories (I.E. Webbing) no longer can be equipped while the XM4 is worn. Armor slots increased to 5 to compensate.
/:cl:

[MobiusWon]

@Birdtalon To answer any “why” you have, this code is borrowed from the integral md that the smartgun has. That being said, I can make the changes you mentioned!

[MobiusWon]

Update: Removed some unnecessary duplicates of code, changed some variables to be more verbose, added some documentation, added suggestions from @Birdtalon, and added a unique description for the XM4 armor.

[MobiusWon]

“Later variants of USCM standard armor included integrated motion trackers, thereby leaving a Marine's hands free to ready their weapon.[[7]] The armor-integrated motion tracker appeared in the corner of a Marine's head-up display and its appearance was very similar to what was displayed on the screen of the handheld tracker. The HUD motion tracker functioned the same as the handheld M314, with a moving object shown on the tracker's display as a series of contours of probable loci and with the range and bearing given to the target. The HUD motion tracker would also display the direction of an objective that the user had active.”

Neat lore that supports this feature. The XM4 could be a prototype version of the integrated motion tracker, that after successful field testing led to it being standard issue.

[Staykeu]

i really dont want this PR to die, but it looks like everyone in the maintainer team is intentionally ignoring it or outright disapproving of it

if this PR goes under i'd recommend trying again but instead of an integral motion detector the XM4 comes with an integral data detector, i feel like that has a higher chance to appeal (or at least just not tick off potential biases within the maint team)

[Birdtalon]

Code seems fine but I do not approve of the PR for design & balance reasons.

[MobiusWon]

Code seems fine but I do not approve of the PR for design & balance reasons.

What needs to change for it to be balanced? First thing that comes to mind is reducing storage.

[Drulikar]

Couple minor things, but otherwise seems to be working.

Also I will note that:

cannot be worn ... by anyone else

Isn't true; there's nothing preventing anyone else from wearing this armor. But I don't know if that needs to change.

[MobiusWon]

Couple minor things, but otherwise seems to be working.

Also I will note that:

cannot be worn ... by anyone else

Isn't true; there's nothing preventing anyone else from wearing this armor. But I don't know if that needs to change.

Want me to change that?

[Staykeu]

Couple minor things, but otherwise seems to be working.
Also I will note that:

cannot be worn ... by anyone else

Isn't true; there's nothing preventing anyone else from wearing this armor. But I don't know if that needs to change.

Want me to change that?

probably could make the armor ID lockable like spec armor, therefore, when an IO permas their armor unlocks and can be repurposed

Resolved