Fix greenfire not mixing well with lighting #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used green fire sprites instead + a recolored 4th tier of the white fire to green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
The current green fire sprites doesn't behave well with green lights - it just blows out all definition in the sprite. There were some unused greenfire sprites in the file so I swapped to those. However there were only 3 of them, so I copied the current white fire and applied basically the same palette to it to make it green. It has the same 1 2 1 2 delay.
Explain why it's good for the game
Fixes #5594
Testing Photographs and Procedure
fire.mp4
Changelog
🆑 Drathek
imageadd: Changed green fire sprites to work better with lights
/:cl: