Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes medal saving #5607

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fixes medal saving #5607

merged 1 commit into from
Feb 1, 2024

Conversation

harryob
Copy link
Member

@harryob harryob commented Jan 31, 2024

posthumous medals would never save because the ckey is nulled immediately on mob changes. this also applies to medals given when you're disconnected for whatever reason

🆑
fix: medals should save more reliably
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jan 31, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to do the Fira request and make this all use weakrefs instead at some point.

@Drulikar Drulikar added this pull request to the merge queue Feb 1, 2024
Merged via the queue into cmss13-devs:master with commit 8520e54 Feb 1, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants