Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes dead tor code #5629

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

harryob
Copy link
Member

@harryob harryob commented Feb 1, 2024

this isn't enabled on the live server, nor would it ever be

🆑
server: tor banning functionality is removed
/:cl:

@harryob harryob requested a review from fira as a code owner February 1, 2024 20:11
@github-actions github-actions bot added the Server Someone call server ops label Feb 1, 2024
@SabreML
Copy link
Member

SabreML commented Feb 1, 2024

There's config section for this too:

## Uncomment this to ban use of ToR
#TOR_BAN

@harryob
Copy link
Member Author

harryob commented Feb 1, 2024

There's config section for this too:

## Uncomment this to ban use of ToR
#TOR_BAN

it is no more

Copy link
Contributor

github-actions bot commented Feb 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 9, 2024
Comment on lines 38 to 41
if(.)
return .

return ..() //default pager ban stuff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is related and you do want to change?

Copy link
Member Author

@harryob harryob Feb 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it escaped from the atomisation chamber of #5628

@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Feb 9, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 12, 2024
Merged via the queue into cmss13-devs:master with commit dde13a9 Feb 12, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Server Someone call server ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants