Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazard Joe Emote Backend #5630

Closed

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Feb 1, 2024

About the pull request

The backend element for Working Joe emote separation so Hazard Joes can use different voice lines.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Added the backend element separation for Working Joe emotes.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Feb 1, 2024
Comment on lines +9 to +10
/// Is used by Hazard Joes.
var/hazard = FALSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just be an optional voice line which is used if the emote is being used by a hazard joe, see the original feedback. no need to have two sets of emotes (and therefore keybindings) given they're the same lines

#3919 (review)

@harryob harryob marked this pull request as draft February 2, 2024 08:16
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 10, 2024
@github-actions github-actions bot closed this Feb 17, 2024
@realforest2001 realforest2001 deleted the project/ares/wjemote branch March 29, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants