[s] Fixes for new 515 features #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isnum returning true for nan is a 515 feature...
Birdtalon
approved these changes
Feb 2, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2024
# About the pull request This PR is a followup to #5633 adding another guard to a handling of numbers this time in TGUI number input. # Explain why it's good for the game Numbers should be numbers. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog No player facing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Apparently these changes are features. Thanks 515.
But in reality, this desperately needs to be tguified.
Explain why it's good for the game
The "features" are not good for the game.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
If you know you know.