Fix for Ceiling(). #5637
Merged
Fix for Ceiling(). #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
approved these changes
Feb 2, 2024
Drulikar
added
the
Testmerge Candidate
cm13-github
added a commit
that referenced
this pull request
Feb 3, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
# About the pull request Following on the heels of #5637 adds parentheses around the arguments of several other global defines, to ensure the order of operations resolves as intended. While some of these aren't strictly necessary due to operator precedence better safe than sorry. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Pre-empts possible issues in the future. # Testing Photographs and Procedure Boots without obvious issue. # Changelog No player-facing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Somebody mentioned seeing incorrect numbers for "you need to play X more xeno hours to unlock prefix/postfix". Turns out,
time_left_until()is defined asCeiling(target_time - current time), which translates to-round( - target_time - current time), or in other words,round(target_time + current_time).In general, any byond macro involving doing math on the argument should probably have that argument bracketed every time it appears to avoid precisely this nonsense.
Explain why it's good for the game
Is fix.
Changelog
🆑
fix: Some cases of calculations for "time remaining until something" no longer display incorrect results.
/:cl: