Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Somebody mentioned seeing incorrect numbers for "you need to play X more xeno hours to unlock prefix/postfix". Turns out,
time_left_until()
is defined asCeiling(target_time - current time)
, which translates to-round( - target_time - current time)
, or in other words,round(target_time + current_time)
.In general, any byond macro involving doing math on the argument should probably have that argument bracketed every time it appears to avoid precisely this nonsense.
Explain why it's good for the game
Is fix.
Changelog
🆑
fix: Some cases of calculations for "time remaining until something" no longer display incorrect results.
/:cl: