Bipod now gives you an option to switch to full auto when deploying #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing bipod, fix some minor logic inconsistencies
github-actions
bot
added
Sprites
|
mby you could rename G to gun and A to action to get rid of single letter vars when you are working on that file, would be nice |
…ightly lightly tested, seems to work
harryob
previously requested changes
Feb 3, 2024
Drulikar
requested changes
Feb 6, 2024
There was a problem hiding this comment.
Minor nitpick, but it seems to only remember the old state early on or when deployed and then gets stuck remembering that state.
- Be on automatic fire
- Enable Full Auto Switch
- Change to burst fire
- Deploy (changes to automatic)
- Retract (returns to burst correctly)
- Change to automatic fire
- Deploy
- Retract (incorrectly returns to burst)
Drulikar
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Attaching the bipod to weapons with full auto capability or firearms marked with the GUN_SUPPORT_PLATFORM flag will give the user a button toggle to immediately switch to full auto when deploying the bipod.
If the full auto switch is turned on, the weapon will simply switch to full auto when the bipod is deployed. If you undeploy it, it will switch back to whatever previous firemode the weapon was in, e.g:
In cases where you switch the weapon's firemode when it's already switched to full auto, it won't revert back to whatever firemode was set before it was deployed, e.g:
Also renames a couple of one letter variables.
Explain why it's good for the game
Quality of life. Less messing around with firemode selectors which is a terrible headache, especially for the HPR, which you usually want to have on full auto 90% of the time. Those who want to stick with the old way don't have to change anything, as the full auto switch is entirely optional.
Testing Photographs and Procedure
Screenshots & Videos
bipod.test.mp4
Changelog
🆑
qol: Attaching the bipod to weapons that have full auto (HPR included) will give you a button toggle for immediately switching to full auto when deploying the bipod.
/:cl: