Revert "Changes to bone repairing (#5280)"

[AlakRacc]

About the pull request

Reverts the PR.

Explain why it's good for the game

This PR does not do what it is supposed to. It does not balance groundside surgery in any way other than making it an annoyance. What could have been done different? Many things.

• Make groundside surgery only available in Colony Medbays.
• Make surgery take longer groundside, even while in a proper surgical theatre.
• Give marines some sort of debuff if they get revived too many times.
• Make surgery give a flat amount of non-healable damage. (Akin to surgical kits in Tarkov)

This PR was just a half-baked attempt at crippling marines. It isn't very well thought out. Changes could further be made to make this PR have an actual effect on gameplay other than what it does currently. Criticism was given to this PR, and it was not taken into consideration.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Alakaya
del: Removed Bonegel Cost
/:cl:

[Drulikar]

This reversion corrupts the Almayer ship map (see checks). Also that's about as weak of an argument for a PR as possible.

[AlakRacc]

This reversion corrupts the Almayer ship map (see checks). Also that's about as weak of an argument for a PR as possible.

Updated. Will look into the corruption.

[Drulikar]

Make groundside surgery only available in Colony Medbays.

I mean sure we can do this - but this has nothing to do with why bonegel usage was introduced.

Make surgery take longer groundside, even while in a proper surgical theatre.

Already the case that medbay surgery is faster than groundside surgery (at least not in a theatre). If you were to fix up a operating theatre though I believe it would be on par with shipside. But again this has nothing to do with the reason why bonegel usage was introduced.

Give marines some sort of debuff if they get revived too many times.

They already do in the form of heart damage - but again this has nothing to do with the reason why bonegel usage was introduced.

Make surgery give a flat amount of non-healable damage. (Akin to surgical kits in Tarkov)

I am not sure where you are going with this suggestion. Bonegel usage doesn't in some way prevent surgery. In fact the PR you propose to revert added the alternative surgery using metal to fix bones too.

---

As I have mentioned in many different places, bonegel/metal is more or less the first consumable for surgery. You could consider drugs and blood otherwise. Bonegel running out is to create a logistical problem. Shipside it practically is infinite, but when taking it groundside you need to get a supply chain with the ship to keep it stocked.

You can expect the vendors that can be used groundside to also have features removed (such as refilling stacks of splints and such) in favor of needing to be restocked with supplies from requisitions. No doubt its a harder logistical problem right now than what it will be once a disposals chute is made between the hangar and requisitions, but by no means has bonegel usage made bone repair surgery impossible.

Ultimately these changes are to make make transport pilots and requisitions more interesting jobs to play. The roadmap task that has existed some time on this is here: https://github.com/orgs/cmss13-devs/projects/6/views/1?pane=issue&itemId=23005516 I have added some additional notes to it today with what changes I want to do for it.

---

I appreciate the enthusiasm to make this PR, and the quality of what you have outlined is drastically better than what you originally opened with. But I will be closing it now to ensure you don't sink more time into something that we aren't going to accept. I hope you can trust that ultimately this will make a more interesting experience in the end. Regardless hopefully this PR has given you some experience in how the development process works. I look forward to seeing your enthusiasm in your next PR.