Revert "Helmet HUDs skip over HUDs that are already in effect on the … #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…player (cmss13-devs#5600)" This reverts commit 56c7062.
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2024
# About the pull request So I am not able to reproduce the runtime spam errors reported in #5656 prompting #5655 but I have added null conditional operators where it is complaining. # Explain why it's good for the game Less runtimes? Fixes #5656 # Testing Photographs and Procedure Untested other than confirming it still seems fine? Please let me know if you know how to reproduce it. # Changelog :cl: Drathek fix: Added more null testing to helmet visors. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…player (#5600)"
This reverts commit 56c7062.
#5600 has broken all helmet HUDs so this is going on TM until it can be fixed so marines who need huds can play.
[22:38:04]RUNTIME: Cannot read null.hudusers - code/modules/clothing/head/helmet.dm@697 (500 total)--
Edit:
More detail this only affects the welding helmet visor not ALL visors.