Fixes crates layering under the fulton recovery system #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable names, 1 to TRUE, and I also removed the bool returns since nothing's actually checking for them.
harryob
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes crates and some other fultonable objects being on a layer below the dropship's fulton recovery system.
This was happening because crates (any closet subtypes really) are on
BELOW_OBJ_LAYER, and dropship equipment is onABOVE_OBJ_LAYER.Changing the layer of
/obj/structure/dropship_equipmentto something lower would probably work, but I felt the safest solution would be to just set the equipment'splaneto whatever the attach point has.This has no effect on the outside attachment points, but fixes the layering issue since the inside ones are on
FLOOR_PLANE.I should also mention that the actual fix is in the first commit (b8e4495) and is only one line. All the rest of this is just because the
install_equipment()proc was a bit confusing as it was.Explain why it's good for the game
Unless I've missed something in git blame, this has probably been a bug for 4+ years.
Testing Photographs and Procedure
Screenshots & Videos
Before:
After: (Also a regular crate too)
Verifying that other hardpoints aren't affected:
Changelog
🆑
fix: Fixed crates and similar objects layering below the dropship's fulton recovery system.
/:cl: