Fix fruit counting and refactor out delete_fruit #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdtalon
reviewed
Feb 9, 2024
Co-authored-by: Birdtalon <[email protected]>
Birdtalon
approved these changes
Feb 10, 2024
cm13-github
added a commit
that referenced
this pull request
Feb 10, 2024
Guidesu
pushed a commit
to Guidesu/cmss13
that referenced
this pull request
Feb 10, 2024
This PR is a follow up to cmss13-devs#5514 where we set picked true to have more accurate messages sent, however this was also checked to skip updating the fruit count in the bound_xeno's action. This PR also refactors out delete_fruit since it just effectively was Destroy anyways. Fixes cmss13-devs#5666 <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/4020e86d-df91-4d44-aaf5-0a338584cbc2 </details> :cl: Drathek fix: Fix gardener fruit count not always updating /:cl: --------- Co-authored-by: Birdtalon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow up to #5514 where we set picked true to have more accurate messages sent, however this was also checked to skip updating the fruit count in the bound_xeno's action. This PR also refactors out delete_fruit since it just effectively was Destroy anyways.
Explain why it's good for the game
Fixes #5666
Testing Photographs and Procedure
Screenshots & Videos
Fruit.mp4
Changelog
🆑 Drathek
fix: Fix gardener fruit count not always updating
/:cl: