Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes custom chemicals not working on the flamer nozzle #5687

Merged
merged 8 commits into from
Mar 1, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Feb 9, 2024

About the pull request

custom chems now work on the flamer nozzle

Explain why it's good for the game

bug fix
may impact balance minorly due to costing less when making a flamer chem cause of the lack of flowing property required when using the nozzle

Testing Photographs and Procedure

2024-02-08.21-30-31.mp4

Changelog

🆑
fix: custom flamer chemicals now work on the flamer nozzle
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Feb 9, 2024
@cuberound
Copy link
Contributor

variables could use renaming T to turf P to projectile and so on please

@iloveloopers
Copy link
Contributor Author

variables could use renaming T to turf P to projectile and so on please

done.
not touching the rest of the code.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 17, 2024
@Birdtalon Birdtalon removed the Stale beg a maintainer to review your PR label Feb 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 29, 2024
code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
code/datums/ammo/ammo.dm Outdated Show resolved Hide resolved
code/datums/ammo/ammo.dm Show resolved Hide resolved
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Feb 29, 2024
@Drulikar Drulikar marked this pull request as draft February 29, 2024 11:27
@iloveloopers iloveloopers marked this pull request as ready for review March 1, 2024 06:11
@Drulikar Drulikar added this pull request to the merge queue Mar 1, 2024
Merged via the queue into cmss13-devs:master with commit ceb17fd Mar 1, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Mar 1, 2024
@iloveloopers iloveloopers deleted the nozzlefix branch March 1, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants