-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive Lesser Drone and Facehugger temporary communication restrictions #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
label
Feb 9, 2024
github-actions
bot
added
the
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
label
Feb 9, 2024
harryob
approved these changes
Feb 10, 2024
harryob
reviewed
Feb 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually one thing,
harryob
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go
cm13-github
added a commit
that referenced
this pull request
Feb 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
# About the pull request This PR is a followup to #5688 to additionally prevent death messages getting sent to the hive during the temporary mute time. # Explain why it's good for the game Ultimately this is to quell more concerns with ghosts using meta knowledge of say a flank approaching and throwing themselves at that flank and informing the hive of the flank via their death message location. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/8b8426bd-8f82-43f6-bb70-a91346c47534 </details> # Changelog :cl: Drathek del: Removed death messages for lesser drones and facehuggers that are still temporarily muted /:cl:
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
# About the pull request This PR is a follow up to #5688 correcting the end message for facehuggers. # Explain why it's good for the game Fixes #5756 # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: Drathek spellcheck: Reworded message when a facehugger's temporary mute ends to not mention hivemind /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR revives and expands #5352. By expand I mean that in addition to a 3 minute restriction for say and hivemind speak, custom emotes and pointing are also restricted during the 3 minute window. Past that I did some additional refactoring.
Explain why it's good for the game
As a ghost role, this acts as a measure to mechanically limit the communication of meta info to other members in the hive. For now the restriction is only 3 minutes.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Zonespace Drathek
balance: Lesser drones and Facehuggers cannot speak, custom emote, or point for 3 minutes after spawning
/:cl: