-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizes both Lesser Drone and Facehugger respawn times to 1 Minute #5691
Conversation
realized when testing there is a lil more I gotta do whoopsies |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
@@ -856,7 +856,7 @@ | |||
return FALSE | |||
if(world.time - user.timeofdeath < JOIN_AS_FACEHUGGER_DELAY) | |||
var/time_left = round((user.timeofdeath + JOIN_AS_FACEHUGGER_DELAY - world.time) / 10) | |||
to_chat(user, SPAN_WARNING("You ghosted too recently. You cannot become a facehugger until 3 minutes have passed ([time_left] seconds remaining).")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the timer not be done as DisplayTimeText(JOIN_AS_FACEHUGGER_DELAY)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for the lesser drone timer
#define JOIN_AS_FACEHUGGER_DELAY (1 MINUTES) | ||
#define JOIN_AS_LESSER_DRONE_DELAY (1 MINUTES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with an increased lesser drone delay.
I do not think we need to make face huggers spawn faster when they already can spawn instantly if they successfully hug.
@@ -911,7 +911,7 @@ | |||
|
|||
if(world.time - user.timeofdeath < JOIN_AS_LESSER_DRONE_DELAY) | |||
var/time_left = round((user.timeofdeath + JOIN_AS_LESSER_DRONE_DELAY - world.time) / 10) | |||
to_chat(user, SPAN_WARNING("You ghosted too recently. You cannot become a lesser drone until 30 seconds have passed ([time_left] seconds remaining).")) | |||
to_chat(user, SPAN_WARNING("You ghosted too recently. You cannot become a lesser drone until 1 minute has passed ([time_left] seconds remaining).")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try using DisplayTimeText
as Beagle had suggested.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Explain why it's good for the game
Total changes:
pt 1: Facehugger respawn time reduced from 3 minutes to 1 minute
Pt 2: Lesser drone respawn time upped from 30 seconds to 1 minute
Right now people spam out lessers because 30 seconds respawn time and people who would go hugger don’t want to wait out the 3 minute time on something that can die to a stray bullet so they just go lesser instead.
This change would make dedicated lesser players less annoying from near instant respawning -> tunnel to frontline and while making dying to a stray bullet from 3 screens away as hugger way less frustrating.
Testing Photographs and Procedure
tested and functional :3
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
balance: Facehugger respawn time reduced from 3 minutes to 1 minute
balance: Lesser drone respawn time upped from 30 seconds to 1 minute
/:cl: