Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forsaken/Feral Xenos can use hive status. #5693

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Feb 10, 2024

About the pull request

due to #5316, the hive status UI checks for a living queen, meaning that hives without living queens (including those that specifically have allow_no_queen_actions (forsaken xenos) were unable to use hive status.

while making this PR I noticed that there were two ways to get hive_status and fixed it(and also carried over the we/you).

don't look at the branch name.

Explain why it's good for the game

I like buffing fixing forsaken xenos. also being able to use hive status is intended

Testing Photographs and Procedure

Screenshots Are here! Click me! forsaken:

image

normal hive (I changed the we/you after this was made)

image

image

Changelog

🆑
fix: Forsaken and Feral xenos can now (correctly) use hive-status
spellcheck: fixed a case where we/our wouldn't be used when attempting to access hive status with no queen
/:cl:

@github-actions github-actions bot added Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Feb 10, 2024
Copy link
Member

@SabreML SabreML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe someone missed this when they made #5316. smh

@SabreML SabreML added this pull request to the merge queue Feb 20, 2024
Merged via the queue into cmss13-devs:master with commit b81570c Feb 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants