Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thour tiny tutorial tweaks (and a unit test) #5695

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Feb 10, 2024

About the pull request

  1. Commit 5014927: Makes the 'Tutorial Menu' automatically close when a tutorial is started.
    • Also adds an abort_tutorial() call to /datum/tutorial/proc/start_tutorial(), since it may have been possible to for player to get trapped in the tutorial otherwise.
  2. Commit b10974c: Adds a tutorial_id to the basic Xenomorph tutorial.
  3. Commit 38c03c9: Edited the tutorial Xenomorph a bit so that it's always "You are Inquisitive Drone (XX-123)", as opposed to "You are Inquisitive Young/Mature/etc. Drone (XX-123)".
  4. Commits a595b97 + 27e38e6: Adds a basic unit test for /datum/tutorial subtypes to verify that they have set some basic variables.
    • Also lightly organises the #includes in code/modules/unit_tests/_unit_tests.dm.

Explain why it's good for the game

Just a couple of things I noticed while exploring tutorial code.
The third commit is maybe a bit subjective, but I personally think it makes the tutorials seem like more of a separate game state, if that makes sense.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
ui: Made the Tutorial Menu automatically close when a tutorial is started.
code: Made the tutorial Xenomorph not inherit the user's 'age' prefix.
code: Added a basic unit test for tutorials.
/:cl:

@SabreML SabreML changed the title Tiny tutorial tweaks Three tiny tutorial tweaks Feb 10, 2024
@SabreML
Copy link
Member Author

SabreML commented Feb 10, 2024

Missed a 'T' opportunity.

@github-actions github-actions bot added UI deletes nanoui/html Code Improvement Make the code longer labels Feb 10, 2024
@SabreML SabreML changed the title Three tiny tutorial tweaks Thour tiny tutorial tweaks (and a unit test) Feb 11, 2024
@harryob harryob added the Unit Tests Keep the game broken, forcefully. label Feb 11, 2024
@harryob
Copy link
Member

harryob commented Feb 11, 2024

well that's depressing

CleanShot 2024-02-11 at 21 26 49@2x

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the unit test!

@Zonespace27 Zonespace27 added this pull request to the merge queue Feb 12, 2024
Merged via the queue into cmss13-devs:master with commit 153b7cf Feb 12, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 12, 2024
@Zonespace27 Zonespace27 added this to the Tutorials milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer UI deletes nanoui/html Unit Tests Keep the game broken, forcefully.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants