-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thour tiny tutorial tweaks (and a unit test) #5695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus a couple of other minor tweaks
Missed a 'T' opportunity. |
github-actions
bot
added
UI
deletes nanoui/html
Code Improvement
Make the code longer
labels
Feb 10, 2024
Zonespace27
reviewed
Feb 10, 2024
Zonespace27
reviewed
Feb 10, 2024
SabreML
changed the title
Three tiny tutorial tweaks
Thour tiny tutorial tweaks (and a unit test)
Feb 11, 2024
Zonespace27
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the unit test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
UI
deletes nanoui/html
Unit Tests
Keep the game broken, forcefully.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
abort_tutorial()
call to/datum/tutorial/proc/start_tutorial()
, since it may have been possible to for player to get trapped in the tutorial otherwise.tutorial_id
to the basic Xenomorph tutorial./datum/tutorial
subtypes to verify that they have set some basic variables.#include
s incode/modules/unit_tests/_unit_tests.dm
.Explain why it's good for the game
Just a couple of things I noticed while exploring tutorial code.
The third commit is maybe a bit subjective, but I personally think it makes the tutorials seem like more of a separate game state, if that makes sense.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
ui: Made the Tutorial Menu automatically close when a tutorial is started.
code: Made the tutorial Xenomorph not inherit the user's 'age' prefix.
code: Added a basic unit test for tutorials.
/:cl: