Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance : set base price for B12 to 30 and for the M4 to 20. #5698

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Feb 11, 2024

About the pull request

1-set base price for B12 to 30 and for the M4 to 20.
2-Medic comtech and SL have a discount of 20% because they have extra supplies to by that are dependent on their role.
3-I also remove the free M4 for the FTL.
4-change price for drop pouch from 15 to 10

If you think M4 base price is to low i can increase it to 25.

if you think discount is to high or low i can change it...

if you think removing M4 to FTL is to much i can give them a discount for armors or just for the M4 lowering it to 16 instead of 20

Explain why it's good for the game

1-base price for B12 was already 30 but i am lowering M4 cost because it only give limited advantage
2-Medic comtech and SL had all some sort of discount for a bunch of items so here i am just picking a discount that seem balance.
3-This is to avoid people choosing FTL for the extra free armor instead of picking Rifleman.
4-I think it's to expensive for what it is and it's very niche use. and because Spartan asked me.
image

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: set base price for B12 to 30 and for the M4 to 20.
balance: Medic comtech and SL have a discount of 20% for the B12 and M4. (B12=24 & M4=16=)
balance: removed the free M4 for FTL but added FTL the option to buy it for 20.
balance: changed the price of Drop Pouch from 15 to 10.
/:cl:

M4 base go at 20 discount for ENGI MEDIC SL of 20%
Because they have extra supplies to by based on their role.
@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 11, 2024
@Huffie56 Huffie56 marked this pull request as ready for review February 11, 2024 09:22
@Huffie56 Huffie56 marked this pull request as draft February 11, 2024 09:43
@Huffie56 Huffie56 marked this pull request as ready for review February 11, 2024 09:52
@Greg-Joffer
Copy link
Contributor

Why are you taking away the FTLs M4? Kinda outta scope....

@Staykeu
Copy link
Contributor

Staykeu commented Feb 12, 2024

Why are you taking away the FTLs M4? Kinda outta scope....

everything other than FTLs losing their free m4 looks good, honestly FTLs could manage just fine without it, but i dont see the reason in removing it

@Huffie56 Huffie56 marked this pull request as draft February 16, 2024 13:54
@Huffie56 Huffie56 marked this pull request as ready for review February 17, 2024 12:37
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 25, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 26, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 26, 2024
Merged via the queue into cmss13-devs:master with commit efccddb Feb 26, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Feb 26, 2024
@Huffie56 Huffie56 deleted the squadmarinearmors branch February 26, 2024 15:18
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2024
# About the pull request

Readds M4 armor to the FTL vendor prep.
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

The removal of the M4 armor by PR #5698 was out of scope for the changes
it brought. The M4 was intended as a unique item for RTOs/FTLs and
removing it because "This is to avoid people choosing FTL for the extra
free armor instead of picking Rifleman" is a rather weak reasoning,
there is no data to support the argument that players pick the FTL
solely for free extra armor.

On any given round it is already difficult to fill the slots for FTL.
Removing features that make the role unique is not the way to go about
increasing quality of the players who choose it, if anything it would
have the opposite effect.

# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>

</details>


# Changelog

:cl:
balance: Readds M4 armor to FTL vendor as a default item
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants