Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes drop pouch not being given to vendors and makes it scale the same as base webbing #5706

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented Feb 12, 2024

About the pull request

makes the droppouch scale with pop, fixes it from being constantly 0

Explain why it's good for the game

bugfix, old value was 0.75 which meant squad vendors were not receiving any. makes it scale like the webbing as requested by drathek

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Drop pouch now scales the same as normal webbing
/:cl:

@Red-byte3D Red-byte3D changed the title makes drop pouch scale the same as base webbing fixes drop pouch not being given to vendors and makes drop pouch scale the same as base webbing Feb 12, 2024
@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 12, 2024
@Red-byte3D Red-byte3D changed the title fixes drop pouch not being given to vendors and makes drop pouch scale the same as base webbing fixes drop pouch not being given to vendors and makes it scale the same as base webbing Feb 12, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 12, 2024
@Drulikar
Copy link
Contributor

See if just
image
resolves the issue you were having. Sorry I didn't have a clear answer from the start what needed to change.

@Drulikar Drulikar marked this pull request as draft February 13, 2024 00:17
@Red-byte3D Red-byte3D marked this pull request as ready for review February 13, 2024 00:32
@Drulikar Drulikar added this pull request to the merge queue Feb 14, 2024
Merged via the queue into cmss13-devs:master with commit 213896b Feb 14, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 14, 2024
@Red-byte3D Red-byte3D deleted the squadprep branch April 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants