Changelog icon size fix (tgfont updates port) #5708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Ports tgstation/tgstation#71808 and tgstation/tgstation#69786 from TG.
The first PR fixes an issue where some changelog icons (specifically those for
soundadd,sounddel,imageadd, andimagedel) appeared a lot smaller than others. (See images below)The second PR adds a VSCode task to rebuild tgfont and copy the result to
tgui\packages\tgfont\staticautomatically, rather than having to runyarn tgfont:buildand copy them there yourself.This task is already mentioned in tgui\packages\tgfont\README_ICON_TUTORIAL.txt, so I'm guessing it was just missed when the rest was ported over.
Explain why it's good for the game
Fixes a bug, and makes it easier to add new font icons in the future.
Testing Photographs and Procedure
Screenshots & Videos
Before:
After:
Changelog
🆑
fix: Fixed some changelog icons being smaller than others.
/:cl: