Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts flare buff from #4229 #5709

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Mister-moon1
Copy link
Contributor

@Mister-moon1 Mister-moon1 commented Feb 12, 2024

About the pull request

Reverts the flare buff that came alongside fancy lighting from 7 range to 5

Explain why it's good for the game

Since the fancy lighting change, other factors have come in to play, most notably the rise in the flare gun, the increase in pouch storage and the buff to armour light, making controlling lighting incredibly easy just with 1, with them being infinitely more difficult to deal with than flashlights and a lot more accessible while being safer to use with other utility.

I believe it is fair to revert the buff especially considering how bright flares are in real life, being more of a concentrated amount of light, not overpowering a military issue flashlight 10 fold without the cone effect to boot.

With how considerable the nerf would be I doubt they will fall into the realm of uselessness, with them still being a great option for scouting ahead of what is visible and still being very easy to carry, just needing an additional flare or so for a room that would be lit up by one.

Testing Photographs and Procedure

https://imgur.com/5VNOQrh

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Reverted flare range buff 7->5 tiles
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 12, 2024
@MobiusWon

This comment was marked as off-topic.

@GoldenDarkness55
Copy link
Contributor

nerf rail flashlights aswell 🙏

@Mister-moon1
Copy link
Contributor Author

I believe that lighting attached to the person is fine because it is a requirement for them to be in the area, flares however are a throw and forget item that linger for a long while, producing more light than anything else and being easy to carry in large amounts

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 23, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine enough; can tweak it later if it proves to be problematic (e.g. maybe larger but more red).

after flare
before flare

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 26, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 26, 2024
Merged via the queue into cmss13-devs:master with commit 7575f2c Feb 26, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Feb 26, 2024
@MaximusRexCM MaximusRexCM mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants