Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopens #4583 (Experimental Tackle Changes) #5712

Closed
wants to merge 8 commits into from

Conversation

Staykeu
Copy link
Contributor

@Staykeu Staykeu commented Feb 13, 2024

About the pull request

Reopens #4583 (description is mostly pulled from it)

This PR removes all randomness from xeno tackles.

If you hit the maximum tackle for the caste you are playing, you will tackle.

Depending on how much damage the person being tackled has it will lower the required tackles.

The minimum required tackle "tap" is succeeded once a human is at or below 70 health.

Alongside this, tackle chances have been moved around to try and account for randomness no longer being a factor.

Three castes in particular have been moved higher on purpose above the others: warriors, lurkers, and runners.

Explain why it's good for the game

Twofold:

Randomness with tackle chance creates insanely unfun situations where you get two tap disarmed by a drone and want to die.

Stun combat is slowly but surely being cut away and we want to encourage people to fight.

Do note, we still want xenos to cap so the maximum damage to reach the minimum amount of tackles is 70 damage. These numbers will be flexible as we see what happens in the tests.

Testing Photographs and Procedure

Screenshots & Videos

Not tested.

Changelog

🆑 Stakeyng
balance: Xeno tackles are no longer random and range in required disarms based on damage to the disarmed. Max damage to get minimum number of tackles is 70.
balance: Alongside xeno tackles being no longer random, pretty much every caste has had tweaks to their disarm related variables. Specific nerfs to: warrior, lurker, and runner.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Feb 13, 2024
@Staykeu Staykeu marked this pull request as draft February 13, 2024 05:37
@hislittlecuzingames
Copy link
Contributor

Looks like the random chance to fail is removed and an additional tile or two of range is being added throughout.

@Staykeu
Copy link
Contributor Author

Staykeu commented Feb 13, 2024

Looks like the random chance to fail is removed and an additional tile or two of range is being added throughout.

this is a compromise for xenos no longer being able to insta-down a full-health marine

@Staykeu Staykeu marked this pull request as ready for review February 13, 2024 06:57
@Red-byte3D
Copy link
Contributor

please properly name the pr

@Staykeu Staykeu changed the title Reopens #4583 Reopens #4583 (Experimental Tackle Changes) Feb 13, 2024
@Staykeu Staykeu marked this pull request as draft February 13, 2024 15:25
@Staykeu
Copy link
Contributor Author

Staykeu commented Feb 13, 2024

WIP until a way for xenos to see a targets damage is implemented.

@private-tristan
Copy link
Contributor

private-tristan commented Feb 13, 2024

here's a handy chart I made for xeno caste to tackles on varying marine HP
image

@Staykeu
Copy link
Contributor Author

Staykeu commented Feb 13, 2024

here's a handy chart I made for xeno caste to tackles on varying marine HP image

i applaud your work but this is could register as an inaccuracy in the future, this PR is still very subject to changes, specifically to the number values

you'd also need to state whether or not health is increasing on descent in the graph, or increase on descent

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 15, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Feb 19, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 22, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 1, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Mar 1, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@morrowwolf
Copy link
Member

There were serious issues to this that I never got around to putting in fixes for. Two things just from memory:
Xenos need a way to tell what "tier" the person they're tackling is at. Whether examining them to give a "they look hurt" message or whatever. Otherwise, this is encouraging just killing instead of capping (which is arguable whether we want or not) and is frustrating to engage with.
Some of the values still seriously needed tweaked. Anything with a stun should generally have a slightly higher number of required tackles to avoid stun->cap guarantees.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Mar 2, 2024
@Staykeu
Copy link
Contributor Author

Staykeu commented Mar 7, 2024

There were serious issues to this that I never got around to putting in fixes for. Two things just from memory: Xenos need a way to tell what "tier" the person they're tackling is at. Whether examining them to give a "they look hurt" message or whatever. Otherwise, this is encouraging just killing instead of capping (which is arguable whether we want or not) and is frustrating to engage with. Some of the values still seriously needed tweaked. Anything with a stun should generally have a slightly higher number of required tackles to avoid stun->cap guarantees.

A sprite/a process of sprites has been made to display human health states, highlighting perfect cap timing, however I'm not skilled enough to implement these sprites myself. If anyone wants to attempt that be my guest, I'll be happy to respond as fast as I can with the file (over discord, unable to be shared on github, unfortunately). Just let me know.

As for the second half, I feel that's something that will be worked out with time, people seem more interested in giving criticisms without specific solutions so it's not terribly obvious which values need to be at what range. If the PR breaks through the issue of the spriting, I'm sure kinks in the delicate balances can be worked out through time and TMs.

@Staykeu
Copy link
Contributor Author

Staykeu commented Mar 13, 2024

This goes without saying but work on this is halted until i get unbanned from the discord server lolololo

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Mar 21, 2024
@github-actions github-actions bot closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants