Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jensenshades are now proper thermal glasses #5716

Closed
wants to merge 3 commits into from

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Feb 13, 2024

About the pull request

JensenShades were a type of thermals that gave you see_mobs but not night vision, with the changes to lighting they don't work anymore as you now need light to see a mob through walls even if you have see_mobs.
this turns them into proper thermal glasses with night vision

Explain why it's good for the game

bug bad
item works now

Testing Photographs and Procedure

probably works

Changelog

🆑
fix: Jensenshades are now proper thermal glasses
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Feb 13, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 21, 2024
@harryob
Copy link
Member

harryob commented Feb 21, 2024

kinda fine with these how they are, honestly. they're 1) meant to be security hud glasses, which this does remove and 2) i don't like rng night vis, i'm so sure we've had to hunt that down before

@harryob harryob closed this Feb 21, 2024
@iloveloopers iloveloopers deleted the jensenshades branch May 7, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants